Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Support GCE in ingress path #9427

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Support GCE in ingress path #9427

wants to merge 1 commit into from

Conversation

ElMehdiBouamama-Infomineo
Copy link

@ElMehdiBouamama-Infomineo ElMehdiBouamama-Infomineo commented Aug 30, 2024 •
edited
Loading

Compatbility with GKE / GCE, where GCE requires a path that contains /* to function properly.
With the current path setup we can't use the /* and it messes up the ingress.

NB: let the user choose his own path, if he wants more complicated paths then he will do it on his own after consulting the documentation. DO NOT FORCE PATHS ON USERS

@ElMehdiBouamama-Infomineo
Fix: Support GCE in ingress path
3115907 
Compatbility with GKE / GCE, where GCE requires a path that contains /* to function and here we can't use the /* and it messes up the ingress.

NB: let the user choose his own path, if he wants more complicated paths then he will do it on his own after consulting the documentation

Signed-off-by: El Mehdi Bouamama <[email protected]>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ElMehdiBouamama-Infomineo
Once this PR has been reviewed and has the lgtm label, please assign desaintmartin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 30, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @ElMehdiBouamama-Infomineo!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 30, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desaintmartin desaintmartin Awaiting requested review from desaintmartin

@maciaszczykm maciaszczykm Awaiting requested review from maciaszczykm

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElMehdiBouamama-Infomineo @k8s-ci-robot @k8s-triage-robot