Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refresh development container #8828

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

feat: refresh development container #8828

wants to merge 9 commits into from

Conversation

shu-mutou
Copy link
Contributor

Support for new Kubernetes Dashboard configuration.
Omitted connecting to an external K8s cluster.
Currently, it only supports kind k8s clusters built by scripts in this repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 23, 2024
@shu-mutou shu-mutou added kind/feature Categorizes issue or PR as related to a new feature. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.88%. Comparing base (7be0753) to head (5f5659f).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8828   +/-   ##
=======================================
  Coverage   35.88%   35.88%           
=======================================
  Files         301      301           
  Lines       14503    14503           
  Branches      202      202           
=======================================
  Hits         5204     5204           
  Misses       9075     9075           
  Partials      224      224

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 23, 2024
@shu-mutou shu-mutou mentioned this pull request Mar 28, 2024
Closed
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 3, 2024
@shu-mutou
Copy link
Contributor Author

@maciaszczykm @floreks PTAL Thanks!

@floreks
Copy link
Member

floreks commented Apr 4, 2024

make serve and make run are broken now and do not work.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 9, 2024
@shu-mutou
Copy link
Contributor Author

/checkcla

@shu-mutou
Copy link
Contributor Author

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 11, 2024
@shu-mutou
Copy link
Contributor Author

@floreks @maciaszczykm dashboard runs properly with this development container.
Please try hack/develop/run-dev-container.sh. Then try followings.

To add a role with full access for development and get its token
to log into the Dashboard, see followings:

1. Run terminal in development container.
    docker exec -it k8s-dashboard-dev gosu user bash

2. Set env for kubeconfig on development container
    export KUBECONFIG=/go/src/github.com/kubernetes/dashboard/.tmp/kubeconfig

3. Add full access role for development.
    kubectl apply -f hack/develop/developmental-role.yaml

4. Run following to get token for logging into dashboard.
    kubectl -n kubernetes-dashboard create token kubernetes-dashboard

5. Access https://localhost:8443/ with browser on your host,
   then login with token.

@floreks
Copy link
Member

floreks commented Apr 11, 2024 •
edited
Loading

What I meant is that running make serve and make run directly in the dashboard root (without using dev container) dir no longer works with these changes applied.

@shu-mutou
Copy link
Contributor Author

@floreks could you check this again?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 29, 2024
@shu-mutou shu-mutou removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 14, 2024
@shu-mutou
Copy link
Contributor Author

@floreks could you check this again?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2024
@shu-mutou
Fix development container
19284b5 
The development container provides developers with a clean environment at all time.
This creates a environment for static check, test, build and execute dashboard on local machine
that is almost the same as CI/CD environment.
@shu-mutou
Fix licence check
a7a3ece
@shu-mutou
Added required Docker version
c90536b
@shu-mutou
Fix how to run development container
f3c8109
@shu-mutou
Add description for development container
3d9be0c
@shu-mutou
Clean up unused sources
f656a18
@shu-mutou
Add description to set kubeconfig
360ef22
@shu-mutou
Fix envs for kubeconfig
59fcc79 
Also, stop using KIND_EXPERIMENTAL_DOCKER_NETWORK.
@shu-mutou
Bump golang to 1.23
5f5659f
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floreks floreks Awaiting requested review from floreks

@maciaszczykm maciaszczykm Awaiting requested review from maciaszczykm

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shu-mutou @k8s-ci-robot @k8s-triage-robot @floreks