Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the events #758

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Refactor the events #758

merged 1 commit into from
Aug 11, 2023

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Aug 8, 2023 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Improve kwok controller performance

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 8, 2023
@netlify
Copy link

netlify bot commented Aug 8, 2023 •
edited
Loading

✅ Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 2dabc6b
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/64d5eb32a2e78b0008101425

@wzshiming wzshiming changed the title Refactor the events [WIP] Refactor the events Aug 8, 2023
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 8, 2023
@wzshiming wzshiming force-pushed the refactor/event branch 11 times, most recently from 264d3e8 to 927ce7d Compare August 8, 2023 12:11
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 8, 2023
@wzshiming wzshiming force-pushed the refactor/event branch 6 times, most recently from f066df8 to d49fb4d Compare August 8, 2023 16:25
@wzshiming wzshiming force-pushed the refactor/event branch 10 times, most recently from feefdcb to 37f5d2c Compare August 10, 2023 03:50
@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Aug 10, 2023
@wzshiming wzshiming force-pushed the refactor/event branch 10 times, most recently from 18a60ff to 04ecfa5 Compare August 10, 2023 11:08
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 10, 2023
@wzshiming wzshiming changed the title [WIP] Refactor the events Refactor the events Aug 11, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2023
@wzshiming wzshiming merged commit 2dc038c into kubernetes-sigs:main Aug 11, 2023
22 of 24 checks passed
@wzshiming wzshiming deleted the refactor/event branch August 11, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@yibozhuang yibozhuang Awaiting requested review from yibozhuang

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wzshiming @k8s-ci-robot