Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Google CloudDNS): add routing policy support #4928

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Dadeos-Menlo
Copy link

Description

Google's CloudDNS service supports routing policies (i.e. geolocation and weighted-round-robin based query responses) but the current implementation of the "google" provider does not support managing such routing policy enabled resource record sets.

The proposed changes include:

  • Introduction of a plan.Changes.All() function, and associated plan.RRSetChange structure, for representing changes to be applied to a managed domain as an ordered sequence of changes grouped by resource record set
  • Refactoring of the "google" provider unit-tests in order to express test expectations in terms of the state of managed domains' resource record sets
  • Modification of the "google" provider to introduce support for handling routing policy enabled resource record sets

Notes:

  • Routing policies introduce additional dimensions to resource records sets (e.g. the regular dimensions of DNS name and record type are augmented by location or weighted set entry) the Endpoint representation of resource records uses the, somewhat AWS Route53 centric, SetIdentifier field to support any additional dimension[s]
  • AWS' Route53 service maintains distinct objects for each routing policy enabled resource record whereas Google's CloudDNS service maintains all of the routing policy configuration within a single ResourceRecordSet object, this data-structure necessitates a read-modify-write approach when attempting to alter a routing policy enabled sub-record
  • The proposed changes introduce a number of "google" provider specific annotations, the getProviderSpecificAnnotations(…) function is modified accordingly but the changes proposed in pull-request 4875 are considered to be a preferable approach

Checklist

  • Unit tests updated
  • End user documentation updated

relying upon the implementation under test to establish the initial test
conditions. Also make mock interface implementations more representative
of real behaviour.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 4, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Dadeos-Menlo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 4, 2024
@mloiseleur
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 22, 2024
@mloiseleur
Copy link
Contributor

/retitle feat(Google CloudDNS): add routing policy support

@k8s-ci-robot k8s-ci-robot changed the title Add routing policy support to Google CloudDNS provider feat(Google CloudDNS): add routing policy support Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants