-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Google CloudDNS): add routing policy support #4928
base: master
Are you sure you want to change the base?
feat(Google CloudDNS): add routing policy support #4928
Conversation
… single resource record set
relying upon the implementation under test to establish the initial test conditions. Also make mock interface implementations more representative of real behaviour.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Dadeos-Menlo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retitle feat(Google CloudDNS): add routing policy support |
Description
Google's CloudDNS service supports routing policies (i.e. geolocation and weighted-round-robin based query responses) but the current implementation of the "google" provider does not support managing such routing policy enabled resource record sets.
The proposed changes include:
plan.Changes.All()
function, and associatedplan.RRSetChange
structure, for representing changes to be applied to a managed domain as an ordered sequence of changes grouped by resource record setNotes:
Checklist