-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pdns): add validation for MX and SRV records #4871
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @julillae. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thanks for this PR, which is tested. |
/retitle feat(pdns): add validation for MX and SRV records |
@mloiseleur That is a great point! I moved the checkEndpoint function to endpoint/endpoint.go. |
Description
Adds a check to validate the format of MX and SRV records. In addition, implements AdjustEndpoints to filter incorrectly formatted records which we know will fail to be created by PowerDNS. This change improves error handling for MX and SRV records and provides a base to validate other record types in the future.
Fixes #ISSUE
Checklist