feat: add logs for policy ignores

[davhdavh]

Description

Log when endpoints changes are dropped due to policy

Fixes #4815

Checklist

• Unit tests updated
• End user documentation updated

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @davhdavh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mloiseleur]

At first glance, it looks like it will generate (potentially) many logs for the same CLI switch.
Since this is the explicit purpose of this policy, I am not sure to see the value of this one.
Did I miss something ?

[davhdavh]

Don't think you missed anything. External-dns is already extremely spammy at debug level, and this certainly would not help with that.
There is however no current way to evaluate what the choosen policy actually does, and therefore there is great value in having it output what it actually does.

[mloiseleur]

The code lgtm. I'm unsure if we should do it or not. I have not a strong opinion on this subject.
I'll let @Raffo make a final decision on this.
/lgtm
/assign @Raffo

[mloiseleur]

/ok-to-test