-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow replica count to be set to zero #4784
base: master
Are you sure you want to change the base?
Allow replica count to be set to zero #4784
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
You may need to add some validation as well. Not sure if external DNS supports HA mode werry well. Having 2+ replicas may throttle DNS API as at the moment there is no leader election. |
The problem is described here a bit #2430. Had a DNS outage once due to this behaviour. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@josh-ferrell Would you please add some validation ? It should fail with replica > 1. FTM, external-dns does not work with more than one pod. |
Description
Allows the replica count for external-dns deployments to be configurable as zero. external-dns helm installs can be done in secondary regions with zero replicas waiting to be scaled up during a failover event. See #4783
The helm chart values.yaml was commented to reflect that external-dns does not support more than one replica.
Checklist