Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow replica count to be set to zero #4784

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

josh-ferrell
Copy link

@josh-ferrell josh-ferrell commented Oct 1, 2024

Description
Allows the replica count for external-dns deployments to be configurable as zero. external-dns helm installs can be done in secondary regions with zero replicas waiting to be scaled up during a failover event. See #4783

The helm chart values.yaml was commented to reflect that external-dns does not support more than one replica.

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stevehipwell for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 1, 2024
@ivankatliarchuk
Copy link
Contributor

You may need to add some validation as well. Not sure if external DNS supports HA mode werry well. Having 2+ replicas may throttle DNS API as at the moment there is no leader election.

@ivankatliarchuk
Copy link
Contributor

The problem is described here a bit #2430. Had a DNS outage once due to this behaviour.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mloiseleur
Copy link
Contributor

@josh-ferrell Would you please add some validation ? It should fail with replica > 1.

FTM, external-dns does not work with more than one pod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants