Merge pull request #4961 from dmarkhas/allow_klog

feat: don't discard klog logs at the highest log levels (debug and trace)
kubernetes-sigs · Dec 26, 2024 · 30ccbcb · 30ccbcb
2 parents 8907080 + 7debf8a
commit 30ccbcb
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/main.go b/main.go
@@ -100,10 +100,12 @@ func main() {
 	}
 	log.SetLevel(ll)
 
-	// Klog V2 is used by k8s.io/apimachinery/pkg/labels and can throw (a lot) of irrelevant logs
-	// See https://github.com/kubernetes-sigs/external-dns/issues/2348
-	defer klog.ClearLogger()
-	klog.SetLogger(logr.Discard())
+	if ll < log.DebugLevel {
+		// Klog V2 is used by k8s.io/apimachinery/pkg/labels and can throw (a lot) of irrelevant logs
+		// See https://github.com/kubernetes-sigs/external-dns/issues/2348
+		defer klog.ClearLogger()
+		klog.SetLogger(logr.Discard())
+	}
 
 	ctx, cancel := context.WithCancel(context.Background())