Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update guideline link to Linux Foundation #3774

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbottum
Copy link
Contributor

@jbottum jbottum commented Jun 21, 2024

Logo link was broken and needed to link to Link Foundation guidelines, https://www.linuxfoundation.org/legal/trademark-usage

Logo link was broken and needed to link to Link Foundation guidelines, https://www.linuxfoundation.org/legal/trademark-usage
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbottum can you please sign off your commits?

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbottum We might need to change it.

@@ -96,7 +96,7 @@ In addition, please check out the community-curated [awesome list of projects an

## Kubeflow Trademark

The Kubeflow trademark and logos are registered trademarks of Google, please review the [Kubeflow Brand Guidelines](https://github.com/kubeflow/community/blob/master/KUBEFLOW_BRAND_GUIDELINES.pdf) for more information.
The Kubeflow trademark and logos are registered trademarks of Google, please review the [Kubeflow Brand Guidelines](https://www.linuxfoundation.org/legal/trademark-usage) for more information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Kubeflow trademark and logos are registered trademarks of Google, please review the [Kubeflow Brand Guidelines](https://www.linuxfoundation.org/legal/trademark-usage) for more information.
The Kubeflow trademark and logos are registered trademarks of the Linux Foundation, please review the [Kubeflow Brand Guidelines](https://www.linuxfoundation.org/legal/trademark-usage) for more information.

@varodrig
Copy link
Contributor

varodrig commented Dec 6, 2024

@jbottum

will you be updating this PR? Thanks!

@Shubhf
Copy link

Shubhf commented Dec 22, 2024

Hello @terrytangyuan Can I take up this issue ?

@terrytangyuan
Copy link
Member

@jbottum Do you want to pick this up again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants