-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Gsoc Expcted Outcome #3685
base: master
Are you sure you want to change the base?
Conversation
Hi @Ayush9026. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this @Ayush9026!
/ok-to-test
/assign @johnugeorge @tenzen-y @rareddy @juliusvonkohout @thesuperzapper @kimwnasptd for the review
Please can you sign your commit for DCO ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding Katib and Training-Operator, LGTM
Signed-off-by: Ayush Gupta <[email protected]>
c3e3a29
to
bf763f8
Compare
@andreyvelich sir signed commit for DCO. |
Correct formatting : Added space after colon Co-authored-by: Andrey Velichkevich <[email protected]>
@Ayush9026 I think, you should sign second commit for both of us. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ayush9026 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0fc3623
to
d0ff35c
Compare
signed-off-by: Andrey Velichkevich <[email protected]> Signed-off-by: Ayush Gupta <[email protected]>
d0ff35c
to
a9196ef
Compare
Hello, I think it is istio-cni and istio ambient mesh, not just the ambient mesh. |
Personally, I think the descriptions that are already there probably give enough context to prospective students. We don't want students being scared off because they think they need to implement the entire thing by themselves. Most of your proposed "expected outcomes" claim the project is about solving the overall problem, rather than just participating in some specific way. For almost all projects, the "expected outcome" is something smaller, like: "you will support the implementation of bigger project yyyyy by delivering xxxxx". |
Also, I am highly suspicious of this PR, as it is clearly trying to hide something (see the strange I am holding for security review. /hold |
@thesuperzapper sir e -i HEAD~2 is by mistakely i will remove it . I completely understand the need for a thorough security review. Please let me know if there's any additional information or assistance I can provide during this process. |
@Ayush9026 I guess that once you squash all commits into one, all DOC errors are resolved. |
@Ayush9026 will you be updating this PR? |
Solve this Issue added GSoC Outcome of all projects #3673
So GSoC Google reviewers can access all information.