style(icon): Update to new twitter logo

[venkyvajrala]

Fixes: #3633

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: venkyvajrala
Once this PR has been reviewed and has the lgtm label, please assign shannonbradshaw for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[google-oss-prow]

Hi @venkyvajrala. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[thesuperzapper]

@venkyvajrala why did you update docsy in this PR?

Also, updating docsy is way more complex than just updating the submodule.

[Arhell]

/ok-to-test

[venkyvajrala]

@thesuperzapper
it has dependency on docsy font-awesome package version. Twitter logo doesn't appear if we don't update the package version of font-awesome to 6.4.2 .I made the change in docsy repo and added the commit which has 6.4.2 package version for font-awesome library.
Please let me know if I am missing anything.

[varodrig]

#3633

@thesuperzapper to review. thanks.

[thesuperzapper]

@venkyvajrala it is not possible to update docsy without a crazy amount of work.

If people really care about the twitter logo, they will need to include it manually (not sure how), or we will need to create a forked version of docsy (starting at our current version) with a newer font-awsome version.

[thesuperzapper]

/hold