Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kubeflow pipeline local deployment docs to support the latest version 1.8.19 #3471

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lokesh-sreedhara
Copy link

Update documentation in reference to #3443.

@google-oss-prow
Copy link

Hi @lokesh-sreedhara. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lokesh-sreedhara
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lokesh-sreedhara
Copy link
Author

@joeliedtke @zijianjoy can u please help review this doc update?

1.8.19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that this 1.8.19 is SDK version, not the backend version. Latest official Backend version is https://github.com/kubeflow/pipelines/releases/tag/1.8.5

Comment on lines +318 to +319
git clone https://github.com/kubeflow/pipelines.git
cd pipelines/manifests/kustomize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the script that doesn't require git clone the repository? It includes downloading the whole codebase, which is not necessary.

@zijianjoy
Copy link
Contributor

Hi @lokesh-sreedhara, thank you for the PR, I wanted to bring to your attention that using version 1.8.19 may not be appropriate as it is a KFP SDK version and not a KFP Backend version. Would you be able to confirm if using the right version with platform-agnostic package works for you?

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@varodrig
Copy link
Contributor

content for latest-version file is not longer valid.
content for local deployment seems to be valid. please move the content to the new page
https://www.kubeflow.org/docs/components/pipelines/legacy-v1/installation/localcluster-deployment/
@lokesh-sreedhara
cc @hbelmiro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants