Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor spelling, grammar fixes in /components folder #3430

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bbrewington
Copy link

No description provided.

@google-oss-prow
Copy link

Hi @bbrewington. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@Arhell Arhell removed their assignment Jan 18, 2023
@jbottum
Copy link
Contributor

jbottum commented Jan 18, 2023

/lgtm

thanks!

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@chensun
Copy link
Member

chensun commented Jun 28, 2023

@bbrewington can you resolve the conflicts?

@varodrig
Copy link
Contributor

varodrig commented Dec 6, 2024

@bbrewington can you resolve the conflicts?
cc @chensun to follow up @terrytangyuan

@google-oss-prow google-oss-prow bot removed the lgtm label Dec 6, 2024
Copy link

New changes are detected. LGTM label has been removed.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added size/XS and removed size/M labels Dec 6, 2024
@varodrig
Copy link
Contributor

@bbrewington can you resolve the conflicts? cc @chensun to follow up @terrytangyuan

@bbrewington can you sign off your commit? https://github.com/kubeflow/website/pull/3430/checks?check_run_id=34052023078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants