Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helm hook to upgrade CRDs #2371

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChenYi015
Copy link
Contributor

@ChenYi015 ChenYi015 commented Dec 24, 2024

Purpose of this PR

Proposed changes:

  • Add a Helm pre-install and pre-upgrade hook job to upgrade CRDs. (Will not rollback CRDs when helm rollback.)
  • Add a new values hook.upgradeCrd (defaults to true).
  • The hook job and RBAC resources will be created only if hook.upgradeCrd is true
  • The RBAC resources related to hook will be deleted immediately when hook job completes.

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from chenyi015. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChenYi015
Copy link
Contributor Author

/hold for review

@ChenYi015
Copy link
Contributor Author

/assign @yuchaoran2011 @jacobsalway @ImpSy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants