Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kubernetes_platform): Add optional field for the secret/configmap as env vars #11486

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(kubernetes_platform): Add optional field for the secret/configmap as env vars #11486

wants to merge 1 commit into from
+261 −227

Conversation

rimolive
Copy link
Member

Description of your changes:
Resolves #11401

Checklist:

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hbelmiro for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DharmitD DharmitD Awaiting requested review from DharmitD

@hbelmiro hbelmiro Awaiting requested review from hbelmiro

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Allow kfp.kubernetes to set optional=True on Secrets and ConfigMaps as environment variables
1 participant
@rimolive