Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Add SemaphoreKey and MutexName fields to proto #11384

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DharmitD
Copy link
Contributor

@DharmitD DharmitD commented Nov 16, 2024

Description of your changes:
This PR introduces semaphoreKey and mutexName fields in PipelineConfig proto to support pipeline-level concurrency controls in KFP.
Pre-requisite to #11340

Checklist:

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign connor-mccarthy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@VaniHaripriya
Copy link
Contributor

/lgtm

@rimolive
Copy link
Member

/lgtm

@HumairAK
Copy link
Collaborator

/ok-to-test

Copy link

Approvals successfully granted for pending runs.

@gregsheremeta
Copy link
Contributor

lgtm but waiting for #11370

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed All CI tests on a pull request have passed do-not-merge/hold lgtm ok-to-test size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants