Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify image and add tls parameters #11259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

YashviP
Copy link

@YashviP YashviP commented Sep 30, 2024

Description of your changes:

Checklist:

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gkcalat for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Hi @YashviP. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -22,7 +22,7 @@ spec:
# * .cloudbuild.yaml and .release.cloudbuild.yaml
# * manifests/kustomize/base/metadata/base/metadata-grpc-deployment.yaml
# * test/tag_for_hosted.sh
image: gcr.io/tfx-oss-public/ml_metadata_store_server:1.14.0
image: docker.intuit.com/personal/y0001/ml_metadata_store_server:1.5.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused, is this a private docker registry?

@HumairAK
Copy link
Collaborator

@YashviP at the moment it's not clear what the intention of this PR is, or what issue it's seeking to resolve.

I would suggest providing a bit more context in your PR body.

@HumairAK
Copy link
Collaborator

/hold

@rimolive
Copy link
Member

Please follow our contribution guidelines to contribute with code. You need to sign-off your commits.

You can find more details in https://www.kubeflow.org/docs/about/contributing/#sign-off-your-commits

@gregsheremeta
Copy link
Contributor

hi Yashvi! Welcome to Kubeflow 😄 Let us know if there's anything we can help you with!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants