Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Allow kfp.kubernetes to set optional=True on Secrets and ConfigMaps as environment variables #11401

Open
tumido opened this issue Nov 22, 2024 · 1 comment · May be fixed by #11486

Comments

@tumido
Copy link
Contributor

tumido commented Nov 22, 2024

Feature Area

/area backend
/area sdk

What feature would you like to see?

Methods kfp.kubernetes.use_secret_as_env and kfp.kubernetes.use_config_map_as_env do not allow to provide optional flag to CMs/Secrets being attached to a pod as environment variables. Kubernetes schema supports it: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.31/#envvarsource-v1-core

kfp.kubernetes already supports the optional flag for *_as_volume methods, but for some reason this is not the case for *_as_env.

What is the use case or pain point?

In case an user wants to use a config maps/secret's property as an environment variable that is needed in the pod only under specific conditions, we have no way of allowing the pod to mount mount it only if the secret/config maps is present. The resource is required to be present all the times, though in many cases it might not be needed.

Is there a workaround currently?

Pipeline author has to always ensure to populate all the requirested secrets/config maps instead of providing only those which are relevant at the time.


Love this idea? Give it a 👍.

@rimolive
Copy link
Member

/assign @rimolive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants