-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Population based training UI #1862
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: a9p The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @a9p. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@a9p: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Changing this request back to WIP: following integration of feedback from #1833, this PR needs to be changed to parse Labels instead of Annotations for metadata. |
@a9p Can you please update with latest review comments so that we can take this in the coming release? |
@johnugeorge this PR has two components:
The first one should be good to use and the changes are encompassed in 593881a and 6145922 (only the prettier needs to be run again on this commit if we want to separate it). The second one I think could use a bit more usability / code feedback and might be a better target for a subsequent cycle. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@a9p Since we release Katib 0.15 recently, do you have some free time to finish this PR ?
It would be nice to give our users ability to monitor PBT Experiments in Katib UI.
Thanks for your effort!
Noting here if anyone has any thoughts -- |
@a9p Yes, we noticed this issue before. |
Hi @a9p, do you have any free time to complete this PR so we can merge it as part of our next release (Katib release-0.16)? |
Hi @andreyvelich, it doesn't look like I will be able to wrap up this PR before feature freeze. Could we push this to the next release target as well? |
Sure, no problem @a9p! |
What this PR does / why we need it:
Support the discovery of modulated hyperparameters rather than attempting to find a fixed set over the entire training process within the Katib UI.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):This PR provides some initial support for PBT within the Katib UI (#1382). Required core changes are introduced in #1833.
Checklist: