-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup test automation for github org tests #678
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Andrea Lamparelli <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lampajr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @lampajr. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I tested the workflow locally using gh act -j tests and this is an extract from the output: | ============================= test session starts ==============================
| platform linux -- Python 3.10.13, pytest-8.2.0, pluggy-1.5.0
| rootdir: /home/alampare/kubeflow/internal-acls/github-orgs
| plugins: asyncio-0.23.6
| asyncio: mode=strict
collected 1 item
|
| test_org_yaml.py . [100%]
|
| ============================== 1 passed in 0.20s ===============================
[Github Org Tests/tests] ✅ Success - Main Run tests
[Github Org Tests/tests] ⭐ Run Post Set up Python 3.10
...
[Github Org Tests/tests] ✅ Success - Post Set up Python 3.10
[Github Org Tests/tests] Cleaning up container for job tests
[Github Org Tests/tests] 🏁 Job succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test |
As highlighted here, currently there is no test automation, thus requiring users to run those tests locally and report the result in the PR.
With this change I am proposing a simple GitHub workflow to automatically trigger GitHub org tests on pull request creation.
This will remove, from user perspective, the need to run those tests locally and report results in the PR itself.