Add node subcommand

[kaelanspatel]

Ref #78.

Adds node subcommand which generates a cost table filtered by individual nodes. Also implements QueryAssets and writeAssetTable which can be modified to be used for other asset types in the future.

Sample output:

+-------------+---------------------------------------------+------------+--------------+--------------+--------------+
| CLUSTER     | NAME                                        | ASSET TYPE | CPU COST     | RAM COST     | TOTAL COST   |
+-------------+---------------------------------------------+------------+--------------+--------------+--------------+
| cluster-one | gke-test-cluster-pool-1-9bb98ef8-cf3j       | e2-medium  |     0.540200 |     0.278558 |     0.818758 |
|             | gke-test-cluster-pool-1-9bb98ef8-kdsf       | e2-medium  |     0.540200 |     0.278558 |     0.818758 |
|             | gke-test-cluster-default-pool-d6266c7c-dqms | e2-medium  |     0.540200 |     0.278557 |     0.818758 |
|             | gke-test-cluster-pool-1-9bb98ef8-3w6g       | e2-medium  |     0.540200 |     0.278557 |     0.818758 |
+-------------+---------------------------------------------+------------+--------------+--------------+--------------+
| SUMMED      |                                             |            | USD 2.160800 | USD 1.114230 | USD 3.275032 |
+-------------+---------------------------------------------+------------+--------------+--------------+--------------+```

Tested locally and cross-referenced with kubecost Assets view.

[dwbrown2]

Awesome!! Have a couple questions/thoughts:

• Are these monthly cost figures by default? If so, should we highlight/indicate somehow?
• I actually think this could make for a really cool blog post, i.e. Seeing the cost of Kubernetes cluster assets with kubectl
• It seems like kubectl cost assets could be a super set of this command, plus LBs, disks, etc. Just an idea..

[michaelmdresser]

It seems like kubectl cost assets could be a super set of this command, plus LBs, disks, etc. Just an idea..

The trouble with this is that each asset type has different fields. We could certainly do kubectl cost assets and have it show only total cost and asset type, but I don't think we can do much more than that.

[dwbrown2]

That would still be useful to me... if you could show asset name, type, cost. Not something we need to explore now, but just throwing it out there. Webb Kubecost, Co-founder ᐧ

…

On Thu, Jun 10, 2021 at 8:05 AM Michael Dresser ***@***.***> wrote: It seems like kubectl cost assets could be a super set of this command, plus LBs, disks, etc. Just an idea.. The trouble with this is that each asset type has different fields. We could certainly do kubectl cost assets and have it show only total cost and asset type, but I don't think we can do much more than that. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#95 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACI25YXL4AZOZHAC7EAA63TSDIEVANCNFSM46NDMEEA> .

[kaelanspatel]

Awesome!! Have a couple questions/thoughts:

• Are these monthly cost figures by default? If so, should we highlight/indicate somehow?
• I actually think this could make for a really cool blog post, i.e. Seeing the cost of Kubernetes cluster assets with kubectl
• It seems like kubectl cost assets could be a super set of this command, plus LBs, disks, etc. Just an idea..

In regards to the first point, the monthly cost is by default. This is in line with the other kubectl cost commands, so I just made it that way for consistency's sake; like the other commands, changing from monthly projected to cumulative over the window is done using the --historical flag.

[michaelmdresser]

Great work so far. I'd also like to see an update to the README ("Usage", see the list of subcommands) and the usage section with an example of kubectl cost node

[michaelmdresser]

If they're hardcoded, don't provide them as options in the struct.

[michaelmdresser]

For aggregate, accumulate, and disableAdjustments, either use the value from the parameter struct or remove the option from the parameter struct entirely. I would recommend removing these from the parameter struct entirely as I don't think we have a use case yet for configuring these and I don't anticipate one soon.

[michaelmdresser]

Great! I'd just ask that you update this list of subcommands:

kubectl-cost/README.md

Line 53 in cfc068e

There are several supported subcommands: `namespace`, `deployment`, `controller`, `label`, `pod`, and `tui`, which display cost information aggregated by the name of the subcommand (see Examples). Each subcommand has two primary modes, rate and non-rate. Rate (the default) displays the projected monthly cost based on the activity during the window. Non-rate (`--historical`) displays the total cost for the duration of the window.

[tsunamishaun]

@michaelmdresser can this make its way into a release? Looking forward to using it :)

[kaelanspatel]

Hi @tsunamishaun.

With the latest release, the node subcommand should be ready for use. Hope it's useful!

[dwbrown2]

Awesome, @kaelanspatel! Do we have plan to support an asset subcommand that would be a general iteration of all paid assets in this cluster? Happy to provide input if you do think something like this could be useful.

[kaelanspatel]

@dwbrown2 Yes, that's definitely something we should do. I think the plan was to either eventually have an asset subcommand like you say (which could be filtered further e.g. asset node), or to simply add more general subcommands which correspond to assets like node does (e.g. lb, disk, cloud).