Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at OCI integration doc #1130

Merged
merged 15 commits into from
Sep 20, 2024
Merged

First pass at OCI integration doc #1130

merged 15 commits into from
Sep 20, 2024

Conversation

Sean-Holcomb
Copy link
Contributor

Related Issue

opencost/opencost#2870

Proposed Changes

Add documentation for setting up an OCI cloud cost integration

Sean-Holcomb and others added 2 commits September 13, 2024 09:59
…pi-cloud-cost-integration.md

Co-authored-by: Thomas Nguyen <[email protected]>
…pi-cloud-cost-integration.md

Co-authored-by: Thomas Nguyen <[email protected]>
Comment on lines 123 to 124
Update the helm values to mount the secret with the configuration
`.Values.kubecostProductConfigs.cloudIntegrationSecret=cloud-integration`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Update the helm values to mount the secret with the configuration
`.Values.kubecostProductConfigs.cloudIntegrationSecret=cloud-integration`
Update the helm values to mount the secret with the configuration.
```yaml
kubecostProductConfigs:
cloudIntegrationSecret: cloud-integration

@thomasvn
Copy link
Member

This first pass is good with me. Any polish that @kwombach12 or @chipzoller want to recommend?

Copy link
Contributor

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're missing an entry here in SUMMARY.md which is the site nav document.

@chipzoller
Copy link
Contributor

Minor linting but Markdown links were supplied backwards.

@chipzoller chipzoller added the 2.4 label Sep 16, 2024
Copy link
Contributor

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Sean. Pushed a last few fixes/tweaks myself to get this in.

@chipzoller chipzoller merged commit 97cc1b0 into main Sep 20, 2024
4 of 5 checks passed
@chipzoller chipzoller deleted the sth/oci-usage-integration branch September 20, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants