Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golang CI #29

Merged
merged 5 commits into from
May 21, 2024
Merged

Golang CI #29

merged 5 commits into from
May 21, 2024

Conversation

chipzoller
Copy link
Collaborator

Signed-off-by: Chip Zoller [email protected]

What does this PR change?

  • Initializes a new Golang CI check

Does this PR rely on any other PRs?

No

How does this PR impact users?

None, CI only.

Links to Issues or tickets this PR addresses or fixes

What risks are associated with merging this PR? What is required to fully test this PR?

Could potentially hold up PRs if it has bugs.

How was this PR tested?

Tested locally but discovered linting issues, logged #28 to address.

Signed-off-by: Chip Zoller <[email protected]>
Signed-off-by: Chip Zoller <[email protected]>
Copy link
Collaborator

@avrodrigues5 avrodrigues5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good addition. Please check after rebasing with #31

@chipzoller
Copy link
Collaborator Author

@avrodrigues5, assuming all is clear, good to cut a new release after this?

@avrodrigues5
Copy link
Collaborator

Yes

@chipzoller chipzoller merged commit c53652d into main May 21, 2024
3 checks passed
@chipzoller chipzoller deleted the cz-golang-ci branch May 21, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants