Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test tree module by programmatically identifying test modules #271

Closed
wants to merge 2 commits into from

Conversation

kirillzh
Copy link

@kirillzh kirillzh commented Oct 4, 2023

An attempt to resolve #266.

I am actually not sure if this resolves the original issue. I tried the snapshot of the plugin locally and it did not help. This seems like a good change to have nonetheless?

I also tried to run unit tests locally to make sure they pass but ran into ./gradlew test:

PluginException: Trying to add extensions to non-registered file type Properties [Plugin: com.intellij.java]

@sksamuel
Copy link
Member

An attempt to resolve #266.

I am actually not sure if this resolves the original issue. I tried the snapshot of the plugin locally and it did not help. This seems like a good change to have nonetheless?

I also tried to run unit tests locally to make sure they pass but ran into ./gradlew test:

PluginException: Trying to add extensions to non-registered file type Properties [Plugin: com.intellij.java]

I have found that isTestModule fails sometimes, even for source sets that are tests. For instance, am trying to do the same thing for the line markers.

Does this change work for you locally ?

@kirillzh
Copy link
Author

Does this change work for you locally?

I don't think it does. I'm not very experienced with plugin development, but what I did is I built a snapshot plugin and installed it in IDE, didn't notice any effect.

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 17, 2024
@Kantis
Copy link
Member

Kantis commented Mar 21, 2024

@kirillzh you can use ./gradlew runIde to start an IDEA instance with your patch applied directly, for shorter turnaround times. The version started is determined by the line

val productName = System.getenv("PRODUCT_NAME") ?: "IC-241"

@kirillzh kirillzh closed this Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running tests from a custom compilation uses wrong Gradle task for tests
3 participants