Delay some style computations until needed #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In DrawDocument() and elementFromPoint(), where we loop thru all the children of an element to check if their y is inside current page, compute only what's needed before tests that can return early. This brings some speedup when turning pages on document that have thousands of small paragraphs in a single body/DocFragment.
This was referenced Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In DrawDocument() and elementFromPoint(), where we loop thru all the children of an element to check if their y is inside current page, compute only what's needed before tests that can return early.
This brings some speedup when turning pages on document that have thousands of small paragraphs in a single body/DocFragment.
Details and some profiling data in #277.