Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue where if enum name starts with letter I it gets cut off f… #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bearow
Copy link

@bearow bearow commented Jul 6, 2020

…rom name in generated interface

@bearow
Copy link
Author

bearow commented Jul 6, 2020

Hey @kondi, I ran across an issue, where typings are incorrect when enum starts with letter "I" (eg. enum named "Iterable" changes into "terable", so I had to fix it for my personal use. What do You think of this? Can You tell if there is a risk of issues with this solution? It looks rather clunky, I didn't mess around a lot with refactoring, because I wanted to make the change as backwards compatible as I can.

the only negative consequence that I meet with is a little bit longer generation time (because there are two loops through ast instead of one)

@bearow
Copy link
Author

bearow commented Jul 6, 2020

(I can add enum into example file that is tested if You think it will add value to tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant