Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added signature pad component #524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Swappea
Copy link
Contributor

@Swappea Swappea commented Nov 7, 2024

  • New component added Signature pad
  • This will allow to get users signature.
  • It also has ability to generate image preview which can be used with image tag to show it to user.
  • it can also be used with html5 forms.

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for kobalte ready!

Name Link
🔨 Latest commit c684b4b
🔍 Latest deploy log https://app.netlify.com/sites/kobalte/deploys/672cf6e45db07d0008236654
😎 Deploy Preview https://deploy-preview-524--kobalte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 83 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jer3m01 jer3m01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Small bug with the image preview; it doesn't seem to fill the <img> fully:
image
Also an option to change the color of the image would be useful.

@jer3m01
Copy link
Member

jer3m01 commented Nov 12, 2024

Will also delay the merge of this component as I'd need to find a way to make it accessible. Open to suggestions!

@Swappea
Copy link
Contributor Author

Swappea commented Nov 12, 2024

Thanks for the PR!

Small bug with the image preview; it doesn't seem to fill the <img> fully: image Also an option to change the color of the image would be useful.

I cannot seem to reproduce the bug, I can see complete image preview. Could you share which device were you using at that time? Look at the attached screenshot.

image
  • As for color, yes I will find a way to send a props to override the default color.
  • As for accessibility, I did searched for it, but I couldn't find much on it. I will continue to do so, if anyone else has any suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants