Upgrade rekt to latest #7076
Upgrade rekt to latest #7076
Conversation
knative-prow
bot
added
the
area/test-and-release
knative-prow
bot
added
approved
|
/test unit-tests |
1 similar comment
|
/test unit-tests |
|
/test upgrade-tests |
| @@ -159,7 +159,7 @@ func IsAddressable(name string, timings ...time.Duration) feature.StepFn { | |||
| } | |||
|
|
|||
| // Address returns a broker's address. | |||
| func Address(ctx context.Context, name string, timings ...time.Duration) (*apis.URL, error) { | |||
There was a problem hiding this comment.
I'm just trying to get a better idea of what's going on in the rekt tests, why are we switching from apis.URL to duckv1.Addressable? Is this because of an api change in the reconciler-test package?
There was a problem hiding this comment.
Yes, this particular change is mostly aligning to the rekt API, in rekt, we needed CA certs from Addressable and having only URL wasn't enough.
There was a problem hiding this comment.
That makes sense, thanks for the clarification!
|
/retest-required |
1 similar comment
|
/retest-required |
|
/retest-required |
1 similar comment
|
/retest-required |
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
pierDipi
force-pushed
the
upgrade-rekt-main-04-07-2023
branch
from
9f4e1d2
to
2817d5b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test upgrade-tests |
|
/retest-required |
1 similar comment
|
/retest-required |
|
Upgrade test seems too much flaky lately ... |
|
/test upgrade-tests |
Manual update since there are a few braking chanages with knative-extensions/reconciler-test#526 first commit upgrade deps and vendor, the rest fixes the issues. --------- Signed-off-by: Pierangelo Di Pilato <[email protected]>
Manual update since there are a few braking chanages with knative-extensions/reconciler-test#526
first commit upgrade deps and vendor, the rest fixes the issues.