Refactor kncloudevent package to be able to use a test client

[creydr]

Currently the kncloudevents.NewRequest always uses an http(s) client to do the requests. This can make unit testing sometimes a bit harder.
This PR addresses it and refactors the package, so we abstract the current behavior behind a new interface (Client) and also adds a new testClient, which kind of mocks the behavior of the http client.

[knative-prow]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[creydr]

/test all

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [creydr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Patch coverage: 66.85% and project coverage change: -0.19 ⚠️

Comparison is base (cb2a891) 78.75% compared to head (268d918) 78.57%.

❗ Current head 268d918 differs from pull request most recent head d60666d. Consider uploading reports for the commit d60666d to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7075      +/-   ##
==========================================
- Coverage   78.75%   78.57%   -0.19%     
==========================================
  Files         248      251       +3     
  Lines       13148    13297     +149     
==========================================
+ Hits        10355    10448      +93     
- Misses       2273     2319      +46     
- Partials      520      530      +10     

Impacted Files	Coverage Δ
pkg/adapter/mtping/runner.go	80.48% <0.00%> (ø)
pkg/reconciler/source/duck/duck.go	74.68% <0.00%> (-2.05%)	⬇️
pkg/resolver/kresource_resolver.go	0.00% <ø> (ø)
pkg/broker/ingress/ingress_handler.go	70.23% <11.11%> (-7.10%)	⬇️
pkg/channel/message_dispatcher.go	73.30% <28.57%> (-1.70%)	⬇️
pkg/kncloudevents/request.go	80.90% <40.00%> (ø)
pkg/kncloudevents/client.go	57.14% <57.14%> (ø)
pkg/broker/ttl.go	71.42% <66.66%> (ø)
pkg/broker/eventtypes.go	72.22% <72.22%> (ø)
pkg/kncloudevents/test/client.go	85.18% <85.18%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[creydr]

/assign @pierDipi

[pierDipi]

Currently the kncloudevents.NewRequest always uses an http(s) client to do the requests. This can make unit testing sometimes a bit harder.

Can you expand on this? what's harder?

[creydr]

Currently the kncloudevents.NewRequest always uses an http(s) client to do the requests. This can make unit testing sometimes a bit harder.

Can you expand on this? what's harder?

tl;dr; with the FakeClient it's not required anymore to spin up a server in a unit test, to check if events were sent, when using a kncloudevents.Client.

In another branch, I am currently working on replacing the CloudEventsSDK client with the kncloudevents package client. The CE SDK client is used in some places with a FakeClient (e.g. in

eventing/pkg/adapter/mtping/runner_test.go

Line 209 in f5b1b12

ce := adaptertesting.NewTestClient()

). So instead of requiring the developer in a unit test to spin up a server with some custom handlers to check if events were sent, I added this FakeClient, which implements the Client interface and provides a method to check the sent events via this client.

[knative-prow]

@creydr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
reconciler-tests_eventing_main	d60666d	link	true	/test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[creydr]

/test unit-tests