Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in type check #83

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Fix typo in type check #83

merged 1 commit into from
Jul 24, 2024

Conversation

Zehvogel
Copy link
Contributor

@Zehvogel Zehvogel commented Jul 24, 2024 •
edited by tmadlener
Loading

BEGINRELEASENOTES

  • Fix a typo in the type checks for creating Associations between TrackerHits and SimTrackerHits.

ENDRELEASENOTES

Originally introduced in #76

@Zehvogel
Fix type direction
7486c72 
copy paste? :)
@tmadlener
Copy link
Contributor

Thanks.

@Zehvogel Zehvogel mentioned this pull request Jul 24, 2024
Closed
@tmadlener
Copy link
Contributor

Looking at this again, I am not sure if this is the entire fix. There are still two distinct maps for handling TrackerHit3D and TrackerHitPlane in the converter, and from the looks of it, only one of them gets passed here for creating the associations. Given that the typo is definitely a bug, I will merge this now and we fix the rest in a follow up PR.

@Zehvogel
Copy link
Contributor Author

Looking at this again, I am not sure if this is the entire fix. There are still two distinct maps for handling TrackerHit3D and TrackerHitPlane in the converter, and from the looks of it, only one of them gets passed here for creating the associations. Given that the typo is definitely a bug, I will merge this now and we fix the rest in a follow up PR.

I fully agree :)

@tmadlener tmadlener changed the title Fix type direction Fix typo in type check Jul 24, 2024
@tmadlener tmadlener merged commit 04850a2 into key4hep:main Jul 24, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zehvogel @tmadlener