Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to always put a CaloHitContribution collection into the event #79

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Make sure to always put a CaloHitContribution collection into the event #79

merged 3 commits into from
Jul 4, 2024

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

  • Always put a CaloHitContribution collection into the event, even if no SimCalorimeterHits have been converted in lcio2edm4hep. Fixes #78

ENDRELEASENOTES

@tmadlener tmadlener mentioned this pull request Jul 2, 2024
Closed
@tmadlener tmadlener force-pushed the fix-missing-calohit-contribs branch from 838d74f to dd83ae4 Compare July 4, 2024 11:20
tmadlener
tmadlener commented Jul 4, 2024
View reviewed changes
standalone/lcio2edm4hep.cpp Outdated Show resolved Hide resolved
@tmadlener tmadlener merged commit f5ed885 into key4hep:main Jul 4, 2024
4 of 6 checks passed
@tmadlener tmadlener deleted the fix-missing-calohit-contribs branch July 4, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seg fault when running lcio2edm4hep?
1 participant
@tmadlener