Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable compiler warnings and fix them #53

Merged
merged 7 commits into from
Mar 12, 2024
Merged

Enable compiler warnings and fix them #53

merged 7 commits into from
Mar 12, 2024

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Feb 20, 2024 •
edited
Loading

BEGINRELEASENOTES

  • Add compiler warnings to the build process
  • Fix compiler warnings

ENDRELEASENOTES

  • Check where this breaks downstream (nowhere if old overloads are properly deprecated)

@tmadlener tmadlener mentioned this pull request Feb 20, 2024
Closed
1 task
tmadlener
tmadlener commented Feb 20, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
tmadlener
tmadlener commented Feb 20, 2024
View reviewed changes
tests/src/ComparisonUtils.h Outdated Show resolved Hide resolved
tests/src/ComparisonUtils.h Outdated Show resolved Hide resolved
This was referenced Feb 20, 2024
Merged
Merged
@tmadlener tmadlener merged commit 70bd626 into key4hep:main Mar 12, 2024
5 of 8 checks passed
@tmadlener tmadlener deleted the add-warnings branch March 12, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tmadlener