Add EDM4hep to LCIO conversion tests from MarlinWrapper #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
edm4hep-to-lcio-tests
branch
2 times, most recently
from
101c39e
to
bafa331
Compare
tmadlener
commented
Sep 27, 2023
tmadlener
force-pushed
the
edm4hep-to-lcio-tests
branch
from
bafa331
to
1c7f4ab
Compare
9 tasks
jmcarcell
reviewed
Oct 4, 2023
tmadlener
commented
Oct 5, 2023
More or less copied from k4MarlinWrapper tests
- Reset SimCalorimeterHit energy after adding Contributions as adding contributions changes the energy - Make sure to populate daughters in the right order in the example MCCollection creation
tmadlener
force-pushed
the
edm4hep-to-lcio-tests
branch
from
d4d6e43
to
caff3e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES