Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cld_steer.py edm4hep output by default #28

Merged
merged 2 commits into from
Mar 26, 2024
Merged

cld_steer.py edm4hep output by default #28

merged 2 commits into from
Mar 26, 2024

Conversation

BrieucF
Copy link
Contributor

@BrieucF BrieucF commented Mar 26, 2024

BEGINRELEASENOTES

  • Change default output file from lcio to edm4hep format in cld_steer.py
  • Remove the comment saying that only lcio is supported in cld_steer.py

ENDRELEASENOTES

Zehvogel
Zehvogel requested changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@Zehvogel Zehvogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx Brieuc, one small suggestion inline. In the end you will probably always want to use --outputFile though.

CLDConfig/cld_steer.py Outdated Show resolved Hide resolved
@BrieucF @Zehvogel
Update CLDConfig/cld_steer.py
8448511 
Co-authored-by: Leonhard Reichenbach <[email protected]>
@Zehvogel Zehvogel merged commit e61d6f3 into main Mar 26, 2024
6 of 8 checks passed
@Zehvogel Zehvogel deleted the edm4hep_output branch March 26, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zehvogel Zehvogel Zehvogel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrieucF @Zehvogel