Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing flaky tests by resetting ConnectionFactory #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OrDTesters
Copy link

Tests in com.github.kevinsawicki.http.HttpRequestTest fail when run after test HttpRequestTest.customConnectionFactory. customConnectionFactory sets the ConnectionFactory instance in HttpRequest to a custom one but fails to reset it back to the default. Later tests, such as postWithVaragsQueryParams, expect the ConnectionFactory to be the default. This proposed fix resets the ConnectionFactory to the default after customConnectionFactory is run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant