Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change prerelease versions suffix to rc #36

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

kennedykori
Copy link
Owner

This is an attempt to improve the latest version selection on Sonatype OSS Nexus Repository. Currently, there is no guarantee that the latest version tags will be updated on each deployment. See this for details.

This is an issue since some tools and services such as javadoc.io, seem to rely on these tags to select the latest version of an artifact correctly. As such, this change tries to address this by using prerelease versions that are friendly to Nexus as described here. Specifically, this changes from using dev as a prerelease tag to rc.

Hopefully, with this change, if the maven-metadata.xml gets rebuilt by Nexus, the latest tag will be updated correctly. This issue provides more details on how and who updates the maven-metadata.xml file.

This is an attempt to improve the latest version selection on [Sonatype
OSS Nexus Repository](https://central.sonatype.org/publish/publish-guide/).
Currently, there is no guarantee that the latest version tags will be
updated on each deployment. See [this](https://support.sonatype.com/hc/en-us/articles/213464638-Why-are-the-latest-and-release-tags-in-maven-metadata-xml-not-being-updated-after-deploying-artifacts-)
for details.

This is an issue since some tools and services such as
[javadoc.io](https://javadoc.io/), seem to rely on these tags to select
the latest version of an artifact correctly. As such, this change tries
to address this by using prerelease versions that are friendly to Nexus
as described [here](https://sonatype.github.io/sonatype-aether/apidocs/org/sonatype/aether/util/version/GenericVersionScheme.html).
Specifically, this changes from using `dev` as a prerelease tag to `rc`.

Hopefully, with this change, if the `maven-metadata.xml` gets rebuilt
by Nexus, the latest tag will be updated correctly. This
[issue](ctapobep/blog#3) provides more
details on how and who updates the `maven-metadata.xml` file.
@kennedykori kennedykori self-assigned this Jan 25, 2024
@kennedykori kennedykori merged commit ddceee7 into develop Jan 25, 2024
2 checks passed
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f4b67b) 100.00% compared to head (fbcb411) 100.00%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##             develop       #36   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       239       239           
===========================================
  Files              1         1           
  Lines            330       330           
  Branches          51        51           
===========================================
  Hits             330       330           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kennedykori kennedykori deleted the ci-change-prerelease-versions-suffix branch January 25, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant