Accept both upper and lowercase 'S' for custom attribute for more compatibility #11420
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why just this placeholder? If we are going to ignore case, then we do it for everything. Looks like we do that for the huge list below already. Ref is the only stand out now. |
|
You are right, I thought it would be too much, but it makes more sense to be consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue that auto type didn't work when using a kdbx from Keepass2.
Other KeePass forks both accept {S:Attr1} and {s:Attr1} as a placeholder for custom attributes. Keepassxc only accepts an uppercase S.
I don't see any risk by accepting both {S: and {s: as placeholder, which will further improve cross compatibility.