Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RabbitMQ: provide separate paremeters for user and password #6180

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dovics
Copy link

@dovics dovics commented Sep 22, 2024

Provide a description of what has been changed

rabbitmq using separate username and password, supports obtaining from environment variables or obtaining from TriggerAuthentication, and remains compatible with previous usage.

Checklist

Fixes #2513

Relates to kedacore/keda-docs#1472

@dovics dovics requested a review from a team as a code owner September 22, 2024 03:28
@dovics dovics changed the title feat: provide separate paremeters for user and password RabbitMQ: provide separate paremeters for user and password Sep 22, 2024
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the improvement :)

@JorTurFer
Copy link
Member

@kedacore/keda-core-contributors PTAL

@JorTurFer
Copy link
Member

JorTurFer commented Oct 2, 2024

/run-e2e rabbit
Update: You can check the progress here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rabbitmq scaler: Allow providing separate paremeters for user and password
2 participants