Adding external cosmos db scaler

[divyagandhisethi]

Provide a description of what has been changed

Checklist

• Commits are signed with Developer Certificate of Origin (DCO)
• A PR is opened to update the documentation on our docs repo

Fixes #

[divyagandhisethi]

@pragnagopa

[tomkerkhove]

This is a good start but think we need some more work.

Main topics are:

• Please add a CI on GitHub Actions
• Removing the deprecated approach and use new instead
• Use connection string parser from official SDK, if available
• Create a file per class instead

Thanks for the PR!

[pragnagopa]

Thanks for the PR! Added few comments. Please add unit test project as well.

[pragnagopa]

I think you need to expose these through config via Options - similar to https://github.com/Azure/azure-webjobs-sdk-extensions/blob/dev/src/WebJobs.Extensions.CosmosDB/Config/CosmosDBOptions.cs

[ahmelsayed]

regarding @tomkerkhove note

Please add a CI on GitHub Actions

@divyagandhisethi I can help set this up if you're not familiar with github actions.

[divyagandhisethi]

regarding @tomkerkhove note

Please add a CI on GitHub Actions

@divyagandhisethi I can help set this up if you're not familiar with github actions.

Thanks. As discussed we will open a tracking issue for adding CI

[divyagandhisethi]

@tomkerkhove Can you please take a look?

[pragnagopa]

Added few more comments. Thanks!

[tomkerkhove]

Created an issue for CI - #2

[tomkerkhove]

A few more things that I'd change to build a solid foundation, but almost there.

Also opened an issue for integration tests: #4

[tomkerkhove]

We definately should do that

[tomkerkhove]

Let's move it to Extensions/StringExtensions instead, otherwise Utilities will become a dump :D

[pragnagopa]

Posting partial feedback.

Main feedback in this iteration - move to https://github.com/Azure/azure-cosmos-dotnet-v3

[pragnagopa]

Added more feedback. Please ping once review is addressed

[pragnagopa]

Added few more comments. Please open an issue here to add E2E test

[pragnagopa]

Changes look good. Please open following issues:

• Add E2E test in K4Apps
• Add readme in this repo - brief description and getting started instructions
• If you do not have already, please follow up setting up CI to produce the right artifacts needed - I recommend publishing artifacts with -beta or -preview in the version / name

[divyagandhisethi]

Changes look good. Please open following issues:

* Add E2E test in K4Apps

* Add readme in this repo - brief description and getting started instructions

* If you do not have already, please follow up setting up CI to produce the right artifacts needed - I recommend publishing artifacts with   -beta or -preview in the version / name

Issue for readme - #3
Issue for integration tests - #4
For CI artifacts - we can generate the preview image manually until we have the CI setup

[divyagandhisethi]

@tomkerkhove This PR is blocked on your review. Please do take a look when possible.

[tomkerkhove]

For CI artifacts - we can generate the preview image manually until we have the CI setup

Let's have a GitHub action to build & push an image to GHCR similar to our core. We use a different experimental tag AFAIK

[tomkerkhove]

@divyagandhisethi Would you mind fixing DCO please?

[tomkerkhove]

What is the status on this PR?

[pragnagopa]

@divyagandhisethi - Please merge the PR once you address DCO

[pragnagopa]

cc @JatinSanghvi and @SushmithaVReddy

[eskaufel]

You are so close... you can do this! 👍🏻

[borqosky]

@divyagandhisethi could you just address DCO?
THIS PR is really interesting and as soon you merge it, I'm going to try it 😺

[divyagandhisethi]

You are so close... you can do this! 👍🏻

Thanks @eskaufel .

[divyagandhisethi]

@divyagandhisethi could you just address DCO?
THIS PR is really interesting and as soon you merge it, I'm going to try it 😺

Thanks @borqosky . The commits are now signed. I don't have write permissions on the repo, so can't merge this PR in.

[divyagandhisethi]

For CI artifacts - we can generate the preview image manually until we have the CI setup

Let's have a GitHub action to build & push an image to GHCR similar to our core. We use a different experimental tag AFAIK

@pragnagopa @JatinSanghvi @SushmithaVReddy - please follow up on this and publish this image as an experimental scaler.

[divyagandhisethi]

@pragnagopa @JatinSanghvi @SushmithaVReddy A PR needs to be open against the docs repo

[tomkerkhove]

@pragnagopa @JatinSanghvi @SushmithaVReddy A PR needs to be open against the docs repo

This is only for built-in scalers but feel free to tackle #7 and use documentation in the README!

[tomkerkhove]

We are planning to surface external scalers on KEDA.sh based on Artifact Hub

[tomkerkhove]

@divyagandhisethi could you just address DCO?
THIS PR is really interesting and as soon you merge it, I'm going to try it 😺

Thanks @borqosky . The commits are now signed. I don't have write permissions on the repo, so can't merge this PR in.

Happy to merge if you want.

[divyagandhisethi]

@divyagandhisethi could you just address DCO?
THIS PR is really interesting and as soon you merge it, I'm going to try it 😺

Thanks @borqosky . The commits are now signed. I don't have write permissions on the repo, so can't merge this PR in.

Happy to merge if you want.

Thanks @tomkerkhove . Yes, please go ahead and merge it in.