Fix traefik registry value #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: galal-hussein <[email protected]>
Signed-off-by: galal-hussein <[email protected]>
briandowns
approved these changes
Nov 6, 2023
osodracnai
approved these changes
Nov 6, 2023
johnatasr
approved these changes
Nov 6, 2023
dereknola
approved these changes
Nov 6, 2023
brandond
approved these changes
Nov 6, 2023
| @@ -1,8 +1,10 @@ | |||
| --- charts-original/values.yaml | |||
| +++ charts/values.yaml | |||
| @@ -3,9 +3,9 @@ | |||
| # -- Traefik image host registry | |||
| registry: docker.io | |||
There was a problem hiding this comment.
Just to be clear, we're dropping support for Values.image.registry because we prepend the system-default-registry to Values.image.repository, and having docker.io added before it here breaks that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.