Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pie-button): DSW-2369 to use @playwright/test & storybook for testing #2109

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

siggerzz
Copy link
Contributor

@siggerzz siggerzz commented Dec 4, 2024

Describe your changes (can list changeset entries if preferable)

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.

  • [-] If changes will affect consumers of the package, I have created a changeset entry.
  • [-] If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@siggerzz siggerzz requested review from a team as code owners December 4, 2024 12:49
Copy link

changeset-bot bot commented Dec 4, 2024

⚠️ No Changeset found

Latest commit: 8758b5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pie-design-system-bot
Copy link
Contributor

pie-design-system-bot commented Dec 4, 2024




Fails
🚫 You have unchecked checklist items outside the "Not-applicable Checklist items" section.

Please ensure all unchecked checkboxes are moved to the appropriate section.

🚫 You have unchecked checklist items in Reviewer 1's section.

Please ensure all items are addressed before approval.

🚫 You have unchecked checklist items in Reviewer 2's section.

Please ensure all items are addressed before approval.

Generated by 🚫 dangerJS against 8758b5d

@siggerzz siggerzz added the work-in-progress This pull request is still a work in progress and may not be ready for review label Dec 4, 2024
private readonly resetPieButton: Locator;
private readonly resetNativeButton: Locator;
private readonly submitPieButton: Locator;
readonly formSubmittedFlag: Locator;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, all locators should be private and only interacted within from within the page object, however, for some cases, it's useful to make them public, so we're able to utilise the Playwright locator assertions - https://playwright.dev/docs/api/class-locatorassertions

@github-actions github-actions bot temporarily deployed to storybook-pr-2109 December 4, 2024 13:13 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2109 December 4, 2024 13:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants