-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(pie-button): DSW-2369 to use @playwright/test & storybook for testing #2109
base: main
Are you sure you want to change the base?
Conversation
|
|
private readonly resetPieButton: Locator; | ||
private readonly resetNativeButton: Locator; | ||
private readonly submitPieButton: Locator; | ||
readonly formSubmittedFlag: Locator; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, all locators should be private and only interacted within from within the page object, however, for some cases, it's useful to make them public, so we're able to utilise the Playwright locator assertions - https://playwright.dev/docs/api/class-locatorassertions
Describe your changes (can list changeset entries if preferable)
Author Checklist (complete before requesting a review, do not delete any)
PIE Storybook
/PIE Docs
PR preview.Not-applicable Checklist items
Please move any Author checklist items that do not apply to this pull request here.
/test-aperture
command.Testing
How do I test my changes?
Reviewer checklists (complete before approving)
Mark items as
[-] N/A
if not applicable.Reviewer 1
PIE Storybook
/PIE Docs
PR preview.Reviewer 2
PIE Storybook
/PIE Docs
PR preview.