fix: using HtmlDisplay trait to show json in html #245
Conversation
ShubhranshuSanjeev
force-pushed
the
fix/override-display
branch
2 times, most recently
from
fa0274a
to
2405022
Compare
| Map::from_iter(vec![ | ||
| (String::from("KEY"), Value::String(k.clone())), | ||
| (String::from("VALUE"), v), | ||
| ]) |
There was a problem hiding this comment.
was this tested? Or can we remove this because of @sauraww 's change earlier?
There was a problem hiding this comment.
This is tested, I am just getting rid of trim logic, as html_display will take care of showing these values without quotes in frontend.
| row.get(cname).unwrap_or(&Value::String("".to_string())), | ||
| ); | ||
| let value: String = | ||
| row.get(cname).unwrap_or(&Value::String(String::new())).html_display(); |
There was a problem hiding this comment.
what difference is html_display creating here ?
There was a problem hiding this comment.
This is similar to generate_table_row_str, just using html_display everywhere for uniformity.
| } | ||
| view | ||
| }} | ||
|
|
||
| </div> | ||
| </div> | ||
| </div> <div class="card bg-base-100 max-w-screen shadow m-5"> | ||
| </div> | ||
| <div class="card bg-base-100 max-w-screen shadow m-5"> | ||
| <div class="card-body"> |
There was a problem hiding this comment.
meanwhile can we also remove this redundant div
| } | ||
| view | ||
| }} | ||
|
|
||
| </div> | ||
| </div> | ||
| </div> <div class="card bg-base-100 max-w-screen shadow m-5"> | ||
| </div> | ||
| <div class="card bg-base-100 max-w-screen shadow m-5"> | ||
| <div class="card-body"> | ||
| <h2 class="card-title">Variants</h2> | ||
| <div class="overflow-x-auto overflow-y-auto"> |
There was a problem hiding this comment.
this as well seems redundant
| for value in values.iter() { | ||
| if value.is_object() && value.get("var").is_some() { | ||
| continue; | ||
| } | ||
|
|
||
| let value_str = match value { |
There was a problem hiding this comment.
can this not be replaced by html_display ?
There was a problem hiding this comment.
Good point, will do it
ShubhranshuSanjeev
force-pushed
the
fix/override-display
branch
from
2405022
to
609514b
Compare
There was a problem hiding this comment.
This change auto-focuses on the dropdown input element whenever it opens up.
| row.get(cname).unwrap_or(&Value::String("".to_string())), | ||
| ); | ||
| let value: String = | ||
| row.get(cname).unwrap_or(&Value::String(String::new())).html_display(); |
There was a problem hiding this comment.
This is similar to generate_table_row_str, just using html_display everywhere for uniformity.
| let experiment = store_value(experiment); | ||
| let contexts = experiment.with_value(|v| v.context.clone()); | ||
| let badge_class = match experiment.with_value(|v| v.status) { | ||
| ExperimentStatusType::CREATED => "badge text-white ml-3 mb-1 badge-xl badge-info", |
There was a problem hiding this comment.
can we avoid repetition over here, the class changing here seems to be badge-info with badge-warning and badge-success
| <label | ||
| tabindex="0" | ||
| class=format!("{} {}", class, btn_class) | ||
| on:click:undelegated=move |_| { |
There was a problem hiding this comment.
also, how was this supposed to work ?
There was a problem hiding this comment.
Didn't get your question
There was a problem hiding this comment.
i was asking how was this change helping in solving the autofocus issue, couldn't understand the logic by looking at the code
There was a problem hiding this comment.
In terms of implementation, I have an input element ref, every click on the button, I am using the input element ref to focus on the input box.
Can you specify what exactly you didn't understand?
There was a problem hiding this comment.
To further add on this, the component library we are using keeps the dropdown mounted on the DOM, so autofocus do focus on the input box but since we make other interactions that focus is lost.
There was a problem hiding this comment.
Other way of doing this can be taking over the logic to display dropdown using signals, but I don't want to manually manage close for any click outside of dropdown.
There was a problem hiding this comment.
keeps the dropdown mounted on the DOM
why is it always mounted ?
shouldn't we just unmount it when not in use
anyways, the behaviour which we simply wanted is the moment it becomes visible (gets mounted in ideal case), the input component should get focused
There was a problem hiding this comment.
shouldn't we just unmount it when not in use
Ideally yes.
why is it always mounted ?
That's how daisy UI does it.
It just changes the visibility to hidden and opacity to 0.
| @@ -86,7 +97,8 @@ where | |||
| type="text" | |||
| class="grow" | |||
| placeholder="Search" | |||
| name=name | |||
| ref_=node_ref | |||
There was a problem hiding this comment.
wont this suffice ?
| ref_=node_ref | |
| autofocus={true} |
There was a problem hiding this comment.
That wasn't working, so went ahead with this approach.
Description
html_displayto render json valuestrimfrom current frontend code