chore(ci): Build using Nix (Ubuntu & macOS) #20
Conversation
- to prevent previous build's test data poping up in another build's test
- whitelists juspay-portal origins
- Validates and authorizes users based on dashboard ACLs - Validates tenant ID in header - Adds an ACL guard for services
- this is needed because the application now uses git dependencies - fixed cac tests dir as well
- variantIds brought to least priority - toss, scope dimensions deleted
- migrated crate names to meet rust standards - decoupled authentication - created OS crate called superposition
srid
force-pushed
the
patch-1
branch
2 times, most recently
from
1d61e12
to
66c7d16
Compare
srid
changed the title
| name: "CI Nix" | ||
| on: | ||
| # Run only when pushing to main branch, and making PRs | ||
| push: |
There was a problem hiding this comment.
@srid can this be manually triggered instead of on every pull request and merge to main?
There was a problem hiding this comment.
@Datron CI should generally run on every PR and on commits to main. Why do you want to run it manually? The latter is risky that people may merge broken PRs into main.
Also, I think I should re-open the PR because someone seemed to have force-pushed to main branch.
There was a problem hiding this comment.
@srid You can just rebase, should get rid of the conflicts. Sorry for the trouble, I force pushed to main.
CI should generally run on every PR and on commits to main. Why do you want to run it manually? The latter is risky that people may merge broken PRs into main.
We already have a code check and build with cargo and tests, would nixci build do the same thing?
There was a problem hiding this comment.
It builds the Rust package (via cargo), runs tests (cargo tests) and effectively makes sure that flake.nix remains not-broken for the user.
Other checks in the existing action like the one below can also be eventually moved to Nix, so that all of our checks run in CI via Nix. Just like it is in nammayatri. If there's consensus for that, I can help with doing it.
superposition/.github/workflows/ci_check_pr.yaml
Lines 64 to 66 in 01110e2
No description provided.