feat: Provide a devShell with packages from enabled services
#355
+58
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivaraj-bh
changed the title
shivaraj-bh
changed the title
devShell with packages from enabled services
srid
reviewed
Oct 9, 2024
nix/services/default.nix
Outdated
| # Output = [ <cfg1> <cfg2> <cfg3> ] | ||
| (lib.foldlAttrs (acc: _: v: (lib.attrValues v) ++ acc) [ ]) | ||
| (lib.filter (service: service.enable)) | ||
| (map (service: service.package)) |
There was a problem hiding this comment.
This assumes that all services -- and services to be added in future -- have package option, right?
nix/services/default.nix
Outdated
Comment on lines
41
to
49
| # `outputs` is a reserved attribute set and is not the name of a service. | ||
| (lib.filterAttrs (n: _: n != "outputs")) | ||
| # Flatten services attrset | ||
| # | ||
| # Example: | ||
| # Input = { mysql."m1" = <cfg1>; mysql."m2" = <cfg2>; redis."r1" = <cfg3>; } | ||
| # Output = [ <cfg1> <cfg2> <cfg3> ] | ||
| (lib.foldlAttrs (acc: _: v: (lib.attrValues v) ++ acc) [ ]) | ||
| (lib.filter (service: service.enable)) |
There was a problem hiding this comment.
You can possibly move this to services.outputs.enabledServices option, thus simplifying the code here.
There was a problem hiding this comment.
This could just be listOf string, fwiw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #194