fix: dynamic tax calculation fix #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImSagnik007
requested review from
seekshiva,
PritishBudhiraja and
ArushKapoorJuspay
as code owners
|
Review changes with SemanticDiff. |
PritishBudhiraja
approved these changes
Sep 16, 2024
github-actions
bot
added
the
Closed
akash-c-k
pushed a commit
that referenced
this pull request
Sep 16, 2024
## [0.87.1](v0.87.0...v0.87.1) (2024-09-16) ### Bug Fixes * dynamic tax calculation fix ([#618](#618)) ([9a321fd](9a321fd))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Dynamic Tax response type changed from integer to float due to compatibility issues.
Sample tax api response:
{ "payment_id": "pay_D1KwskbRrHs2wZcXzi6w", "net_amount": 4190, "order_tax_amount": 190, "shipping_cost": 1000, "display_amount": { "net_amount": "41.90", "order_tax_amount": "1.90", "shipping_cost": "10.00" } }How did you test it?
Checklist
npm run re:build