refactor: HS-12345: Refactor Payment Element shimmer, Modal setState #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated set state moved repeating ui to loop
updated on comments
| @react.component | ||
| let make = () => { | ||
| <div className="flex flex-col gap-4"> | ||
| <ElementShimmer n=2 /> |
There was a problem hiding this comment.
if n is always going to be 2, it might as well not exist as a prop
jaggaroshu
requested review from
akash-c-k and
ArushKapoorJuspay
as code owners
prafulkoppalkar
approved these changes
Feb 27, 2024
PritishBudhiraja
approved these changes
Mar 5, 2024
ArushKapoorJuspay
pushed a commit
that referenced
this pull request
Sep 23, 2024
Bank Changes Added * Bank Changes Added Approved-by: Praful Koppalkar
ArushKapoorJuspay
pushed a commit
that referenced
this pull request
Sep 23, 2024
Merge in EXC/orca-elements from praful/removed_Country_from_card to master * commit 'd4a175129e017c6e97b15bdfb1a301a85fb5eb60': commented it out for future Removed country from card form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated set state
moved repeating Shimmer Ui to loop