Merge pull request #46 from juspay/env-variables

Add defaults for some env variables and fix build warnings
juspay · Aug 27, 2024 · aafa1b4 · aafa1b4
2 parents 67f2b99 + 48c39b3
commit aafa1b4
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 15 deletions.
diff --git a/src/lib/env.mjs b/src/lib/env.mjs
@@ -10,7 +10,7 @@ export const env = createEnv({
    */
   server: {
     ENV: z.enum(["development", "test", "staging", "production"]).default("development"),
-    SECRET_KEY: z.string().min(8, { message: "Cannot be too short" }),
+    SECRET_KEY: z.string().min(8, { message: "Cannot be too short" }).default("secretkey123456"),
     SENTRY_DSN: z.string().min(1).optional(),
     APL: z.enum(["saleor-cloud", "upstash", "file"]).optional().default("file"),
     CI: z.coerce.boolean().optional().default(false),
@@ -26,12 +26,11 @@ export const env = createEnv({
     REST_APL_TOKEN: z.string().optional(),
     APP_API_BASE_URL: z.string().optional(),
     APP_IFRAME_BASE_URL: z.string().optional(),
-    HYPERSWITCH_SANDBOX_BASE_URL: z.string(),
-    HYPERSWITCH_PROD_BASE_URL: z.string(),
-    JUSPAY_SANDBOX_BASE_URL: z.string(),
-    JUSPAY_PROD_BASE_URL: z.string(),
+    HYPERSWITCH_SANDBOX_BASE_URL: z.string().default("https://sandbox.hyperswitch.io"),
+    HYPERSWITCH_PROD_BASE_URL: z.string().default("https://api.hyperswitch.io"),
+    JUSPAY_SANDBOX_BASE_URL: z.string().default("https://sandbox.juspay.in"),
+    JUSPAY_PROD_BASE_URL: z.string().default("https://api.juspay.in"),
   },
-
   /*
    * Environment variables available on the client (and server).
    *

diff --git a/src/modules/ui/molecules/AddConfigButton/AddConfigButton.tsx b/src/modules/ui/molecules/AddConfigButton/AddConfigButton.tsx
@@ -17,15 +17,21 @@ export const AddConfigButton = ({ ...props }: AddConfigButtonProps) => {
     setState("prompt");
   }, []);
 
-  const handleOutsideIndiaClick = useCallback<MouseEventHandler<HTMLButtonElement>>((e) => {
-    e.preventDefault();
-    void router.replace("/configurations/add/hyperswitch");
-  }, []);
+  const handleOutsideIndiaClick = useCallback<MouseEventHandler<HTMLButtonElement>>(
+    (e) => {
+      e.preventDefault();
+      void router.replace("/configurations/add/hyperswitch");
+    },
+    [router],
+  );
 
-  const handleIndiaClick = useCallback<MouseEventHandler<HTMLButtonElement>>((e) => {
-    e.preventDefault();
-    void router.replace("/configurations/add/juspay");
-  }, []);
+  const handleIndiaClick = useCallback<MouseEventHandler<HTMLButtonElement>>(
+    (e) => {
+      e.preventDefault();
+      void router.replace("/configurations/add/juspay");
+    },
+    [router],
+  );
 
   const handleOpenChange = useCallback((open: boolean) => {
     setState(open ? "prompt" : "idle");

diff --git a/src/pages/api/manifest.ts b/src/pages/api/manifest.ts
@@ -12,7 +12,7 @@ import { transactionProcessSessionSyncWebhook } from "./webhooks/saleor/transact
 export default createManifestHandler({
   async manifestFactory(context) {
     const manifest: AppManifest = {
-      id: "app.saleor.juspay-test",
+      id: "app.saleor.juspay",
       name: "Juspay",
       about: packageJson.description,
       tokenTargetUrl: `${context.appBaseUrl}/api/register`,