Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updated business profiles #1346

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

chore: updated business profiles #1346

wants to merge 15 commits into from

Conversation

gitanjli525
Copy link
Contributor

@gitanjli525 gitanjli525 commented Sep 10, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Updated business profiles
View profile details and update webhook details inside business profile (that currently is under payment-settings)
image
image

Motivation and Context

moving all profile related details to business profile instead of payment-setting

How did you test it?

working as described in description

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@gitanjli525 gitanjli525 self-assigned this Sep 10, 2024
@gitanjli525 gitanjli525 requested a review from a team as a code owner September 10, 2024 13:23
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@gitanjli525 gitanjli525 linked an issue Sep 10, 2024 that may be closed by this pull request
combine payment settings and business profile #1347
Open
@gitanjli525 gitanjli525 added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Sep 11, 2024
@gitanjli525 gitanjli525 added S-in-progress Status: Implementation is underway and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Sep 13, 2024
@gitanjli525 gitanjli525 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed core Status: issues related to core and removed S-in-progress Status: Implementation is underway labels Sep 13, 2024
PritishBudhiraja
PritishBudhiraja previously approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@PritishBudhiraja PritishBudhiraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise Looks Good :)

Riddhiagrawal001
Riddhiagrawal001 reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@Riddhiagrawal001 Riddhiagrawal001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add edit profile name functionality . Currently its always going to the profile details
Refer to existing business-profile page in sbx

@gitanjli525 gitanjli525 added S-in-progress Status: Implementation is underway and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Sep 19, 2024
@gitanjli525 gitanjli525 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-in-progress Status: Implementation is underway labels Sep 19, 2024
@gitanjli525
Copy link
Contributor Author

Please add edit profile name functionality . Currently its always going to the profile details Refer to existing business-profile page in sbx

okay

@gitanjli525 gitanjli525 added S-blocked Status: Blocked on something else or other implementation work and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Riddhiagrawal001 Riddhiagrawal001 Riddhiagrawal001 approved these changes

@JeevaRamu0104 JeevaRamu0104 Awaiting requested review from JeevaRamu0104

@PritishBudhiraja PritishBudhiraja Awaiting requested review from PritishBudhiraja

@sagarnaikjuspay sagarnaikjuspay Awaiting requested review from sagarnaikjuspay

At least 2 approving reviews are required to merge this pull request.

Assignees

@gitanjli525 gitanjli525

Labels
core Status: issues related to core S-blocked Status: Blocked on something else or other implementation work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

combine payment settings and business profile
5 participants
@gitanjli525 @Riddhiagrawal001 @PritishBudhiraja @JeevaRamu0104 @sagarnaikjuspay