Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename metaschema's $defs/simpleTypes to singular #1467

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

notEthan
Copy link
Contributor

@notEthan notEthan commented Nov 3, 2023

This is somewhat trivial but I think this is more correct. The string is a simple type, not multiple types.

@gregsdennis
Copy link
Member

I think it's correct as is. It's common to name an enumeration type as the plural, effectively stating, "There are the available X." In this case, this definition is listing the available types.

@notEthan
Copy link
Contributor Author

notEthan commented Nov 4, 2023

All the other $defs names refer to the contents of the instance, not what's in the schema. I have only ever seen conventions of naming $defs names per the instance described.
But, I thought this would be trivial/noncontroversial, not particularly wanting to debate it, so if that is not accurate, I am not bothered if you close this (or I can).

@gregsdennis
Copy link
Member

I'm happy to get other opinions, but plural makes most sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants