Less time for building meteor project #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openmove
changed the title
gustawdaniel
approved these changes
Jul 5, 2018
There was a problem hiding this comment.
I did not tested this code but concept is great. I think that developing of this repository should go in this direction. Execution all installs of system dependencies any time in Continuous Integrations systems is with disagree with idea of docker container - small layer with constrained responsibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have less time for building a meteor project, we have split the logic in 2 docker images.
The first one tagged 'base' contains the SO with all the updates and installs needed.
The second one tagged 'onbuild' take care of all the configurations specified in the launchpad.conf and compile the meteor project.
When someone needs to build the meteor project image, he/she has to create a Dockerfile only with the 'onbuild' tagged image.